You did a good effort.

[Sureshvemuri]

If somebody modified a file -

Is this okay to say "You did a good effort." (effort may contain many many jobs/tasks??)

OR

"You did a good job".

Thanks,
Suresh

[Beginner2]

You did a good job is more appropriate. This implies a person has finished a task.

You did a good effort should be "You made a good effort". This implies a person has tried but not necessarily complete the task.

My 2cents, could be wrong though.